Skip to content

Conversation

sweatybridge
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from soedirgo as a code owner August 10, 2022 04:58
soedirgo
soedirgo previously approved these changes Aug 10, 2022
@soedirgo
Copy link
Member

We should still keep --password on db push so people can use it in CI

@sweatybridge sweatybridge requested a review from soedirgo August 10, 2022 05:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2830365194

  • 31 of 64 (48.44%) changed or added relevant lines in 5 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 24.608%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/remote/commit/commit.go 0 1 0.0%
cmd/db.go 4 6 66.67%
internal/db/push/push.go 0 2 0.0%
cmd/link.go 5 17 29.41%
internal/link/link.go 22 38 57.89%
Files with Coverage Reduction New Missed Lines %
cmd/link.go 6 29.03%
internal/link/link.go 10 41.51%
Totals Coverage Status
Change from base Build 2830012380: -0.3%
Covered Lines: 1241
Relevant Lines: 5043

💛 - Coveralls

@soedirgo soedirgo merged commit f3bad1e into main Aug 10, 2022
@soedirgo soedirgo deleted the link-pass branch August 10, 2022 05:53
@github-actions
Copy link

🎉 This PR is included in version 0.38.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants