Skip to content

Conversation

avallete
Copy link
Member

@avallete avallete commented Jun 7, 2025

What kind of change does this PR introduce?

  • Feat: add hot reloading to functions serve command
  • Functions url's in the serve command
Screen.Recording.2025-06-10.at.12.01.27.mov
Screenshot 2025-06-09 at 10 14 32

@coveralls
Copy link

coveralls commented Jun 7, 2025

Pull Request Test Coverage Report for Build 15585019893

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 368 of 536 (68.66%) changed or added relevant lines in 8 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 55.511%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/colors.go 0 3 0.0%
internal/utils/logger.go 9 16 56.25%
internal/functions/serve/serve.go 34 59 57.63%
internal/functions/serve/service.go 134 169 79.29%
internal/functions/serve/watcher.go 140 188 74.47%
internal/functions/serve/test_helpers.go 35 85 41.18%
Files with Coverage Reduction New Missed Lines %
internal/functions/serve/serve.go 4 52.22%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 15579624203: 0.4%
Covered Lines: 6280
Relevant Lines: 11313

💛 - Coveralls

@avallete avallete force-pushed the avallete/devwf-439-hot-reload-eszip-bundle-when-function-source-changes branch from acf5303 to eda966d Compare June 7, 2025 15:45
@avallete avallete marked this pull request as ready for review June 9, 2025 08:20
@avallete avallete requested a review from a team as a code owner June 9, 2025 08:20
@avallete avallete requested a review from sweatybridge June 10, 2025 10:05
@avallete avallete marked this pull request as draft June 11, 2025 09:23
@avallete avallete marked this pull request as ready for review June 11, 2025 15:01
@avallete
Copy link
Member Author

Closing in favor of: #3710

@avallete avallete closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants