fix: 2nd pass when pulling initial schema #4357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the new behavior?
We have these default privileges for all new tables created in public schema.
As a user, I may want to create a new table but revoke grants to
anonrole. For eg. my migration could look like thisNow if I run the diff tool against an empty database, our inspection query finds a new table created with grants to
authenticatedandservice_roleonly. So it generates the following sqlThis is actually inconsistent with my desired state because the table
public.testwill still be granted toanonrole due to the default privilege.Hence, we are doing a 2nd pass to properly capture the revoke statements.
Additional context
Add any other context or screenshots.