-
Notifications
You must be signed in to change notification settings - Fork 317
chore: remove GH_PAT usage and NPM_TOKEN #4510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All npm publishing must be done through Trusted Publisher. GH_PAT should not be used and a dedicated GitHub app with tightly scoped permissions is to be used instead.
Pull Request Test Coverage Report for Build 19675985113Details
💛 - Coveralls |
| - run: npm dist-tag add "supabase@${RELEASE_TAG#v}" latest | ||
| env: | ||
| RELEASE_TAG: ${{ inputs.release }} | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious where is trusted publisher configured?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is configured in npmjs.com - busy setting it up with copple now (edit: configuration done)
.github/workflows/api-sync.yml
Outdated
| run: gh pr merge --auto --squash "${{ steps.cpr.outputs.pull-request-number }}" | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GH_PAT }} | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need the app token here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, there has since been a setting change that allows Actions that are not from a on: or pull_request: trigger to create and approve PRs. Maybe merge isn't covered 🤔 - I can switch that to use the GitHub app too, probably safer
What kind of change does this PR introduce?
CI/CD update
Additional context
All npm publishing must be done through Trusted Publisher. GH_PAT should not be used and a dedicated GitHub app with tightly scoped permissions is to be used instead.