fix: ensure conf.d directory exists for postgres 17 compatibility #4570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new postgres image (17.6.1.058) includes an include_dir directive in postgresql.conf that requires /etc/postgresql-custom/conf.d to exist. When upgrading from older CLI versions, existing config volumes do not contain this directory. Docker does not copy image contents when mounting a volume that already has data, causing postgres to fail with: could not open configuration directory /etc/postgresql-custom/conf.d This fix adds mkdir -p to create the directory before postgres starts, ensuring backwards compatibility with existing volumes. Closes supabase/supabase#41012
Pull Request Test Coverage Report for Build 19889610058Details
💛 - Coveralls |
Contributor
Author
|
@sweatybridge Please review, when available! |
Contributor
|
closing for a different fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix for backwards compatibility with existing config volumes after CLI upgrade.
What is the current behavior?
After upgrading to CLI v2.65.2 (which uses postgres image 17.6.1.058),
supabase startfails with:What is the new behavior?
The CLI now creates the
conf.ddirectory before starting postgres, ensuring backwards compatibility with existing volumes.Root cause
The new postgres image includes
include_dir = '/etc/postgresql-custom/conf.d'in postgresql.conf. When an existing config volume (from older CLI versions) is mounted, Docker does not copy image contents to the volume, so theconf.ddirectory is missing.Fix
Added
mkdir -p /etc/postgresql-custom/conf.dto the entrypoint script before postgres starts. This is idempotent and safe for both new and existing volumes.Closes #4571