feat: WebSocket upgrade support #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyannyacha
force-pushed
the
feat-ws-listen
branch
from
2f87a36 to
6d339ae
Compare
Contributor
Author
|
Note: Tests are passed, but there is no test for the WebSocket upgrade case. I need to write a test 😋 |
nyannyacha
force-pushed
the
feat-ws-listen
branch
from
6d339ae to
40610cc
Compare
nyannyacha
force-pushed
the
feat-ws-listen
branch
2 times, most recently
from
56a4ec0 to
83ee333
Compare
Contributor
Author
|
ready for review 😋 |
nyannyacha
commented
Feb 21, 2024
| abortController, | ||
| ); | ||
|
|
||
| return { request, respondWith, streamRid }; |
Contributor
Author
There was a problem hiding this comment.
Note: This is the only purpose this file exists for.
We need streamRid for protocol upgrades, but Deno hasn't exposed it at all.
nyannyacha
requested review from
andreespirela and
laktek
and removed request for
andreespirela
laktek
reviewed
Feb 23, 2024
nyannyacha
force-pushed
the
feat-ws-listen
branch
from
2184058 to
b9f26a5
Compare
nyannyacha
force-pushed
the
feat-ws-listen
branch
from
b9f26a5 to
5d8be90
Compare
laktek
approved these changes
Feb 27, 2024
|
🎉 This PR is included in version 1.37.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Description
This PR is to make it possible for the (user/main) worker to upgrade incoming requests to the WebSocket protocol.
Breaking changes
EdgeRuntime.applyConnectionWatcheris replaced byEdgeRuntime.applySupabaseTagThis change is a result of the need to track multiple pieces of data.