Skip to content

fix(ext/node): comment out op_geteuid and op_getegid #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

fix(ext/node): comment out op_geteuid and op_getegid #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions ext/node/ops/os/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,44 +214,46 @@ where

#[op2(fast, stack_trace)]
pub fn op_geteuid<P>(
state: &mut OpState,
_state: &mut OpState,
) -> Result<u32, deno_core::error::AnyError>
where
P: NodePermissions + 'static,
{
{
let permissions = state.borrow_mut::<P>();
permissions.check_sys("uid", "node:os.geteuid()")?;
}
// {
// let permissions = state.borrow_mut::<P>();
// permissions.check_sys("uid", "node:os.geteuid()")?;
// }

#[cfg(windows)]
let euid = 0;
#[cfg(unix)]
// SAFETY: Call to libc geteuid.
let euid = unsafe { libc::geteuid() };
// #[cfg(windows)]
// let euid = 0;
// #[cfg(unix)]
// // SAFETY: Call to libc geteuid.
// let euid = unsafe { libc::geteuid() };

Ok(euid)
// Ok(euid)
Ok(0)
}

#[op2(fast, stack_trace)]
pub fn op_getegid<P>(
state: &mut OpState,
_state: &mut OpState,
) -> Result<u32, deno_core::error::AnyError>
where
P: NodePermissions + 'static,
{
{
let permissions = state.borrow_mut::<P>();
permissions.check_sys("getegid", "node:os.getegid()")?;
}
// {
// let permissions = state.borrow_mut::<P>();
// permissions.check_sys("getegid", "node:os.getegid()")?;
// }

#[cfg(windows)]
let egid = 0;
#[cfg(unix)]
// SAFETY: Call to libc getegid.
let egid = unsafe { libc::getegid() };
// #[cfg(windows)]
// let egid = 0;
// #[cfg(unix)]
// // SAFETY: Call to libc getegid.
// let egid = unsafe { libc::getegid() };

Ok(egid)
// Ok(egid)
Ok(0)
}

#[op2(stack_trace)]
Expand Down