Skip to content

fix(dockerfile): install ca certs#664

Merged
nyannyacha merged 2 commits intomainfrom
ny/dockerfile-cert
Feb 23, 2026
Merged

fix(dockerfile): install ca certs#664
nyannyacha merged 2 commits intomainfrom
ny/dockerfile-cert

Conversation

@nyannyacha
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix

Description

Fixes #663

@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Chores
    • Improved TLS/CA certificate handling in the deployment images so certificates are installed and refreshed during both build and runtime stages, ensuring secure network communications across environments.

Walkthrough

This change updates the Dockerfile to install the ca-certificates package in both the build stage and the final edge-runtime image, and runs update-ca-certificates. The modifications ensure the system CA store is present and updated at build and runtime, addressing TLS certificate availability for processes running inside the container.

Sequence Diagram(s)

Assessment against linked issues

Objective Addressed Explanation
Add ca-certificates package and invoke update-ca-certificates in Dockerfile [#663]

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
Dockerfile (1)

58-63: ⚠️ Potential issue | 🟠 Major

Install CA certificates in the CUDA runtime image too.

edge-runtime-cuda is built from nvidia/cuda, so the CA store added in edge-runtime-base isn’t present. TLS in the CUDA image can still fail with “no CA certificates found.” Install/update certs (or copy /etc/ssl/certs from the base stage).

💡 Suggested fix
 FROM nvidia/cuda:11.8.0-cudnn8-runtime-ubuntu22.04 as edge-runtime-cuda
+
+RUN apt-get update && apt-get install -y ca-certificates \
+    && update-ca-certificates \
+    && rm -rf /var/lib/apt/lists/*
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Dockerfile` around lines 58 - 63, The CUDA runtime stage edge-runtime-cuda is
missing system CA certs (the edge-runtime-base stage added them), causing TLS
failures; fix by ensuring certs are present in the edge-runtime-cuda
stage—either run the distro's cert update/install command (e.g., install
ca-certificates and update-ca-certificates) inside the edge-runtime-cuda stage
or copy the certificate store from edge-runtime-base (e.g., COPY
--from=edge-runtime-base /etc/ssl/certs /etc/ssl/certs and related files);
update the Dockerfile near the edge-runtime-cuda stage (the lines referencing
FROM nvidia/cuda:11.8.0-cudnn8-runtime-ubuntu22.04 and COPY
--from=edge-runtime-base ...) to include one of these steps so TLS can find CA
certificates at runtime.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@Dockerfile`:
- Around line 58-63: The CUDA runtime stage edge-runtime-cuda is missing system
CA certs (the edge-runtime-base stage added them), causing TLS failures; fix by
ensuring certs are present in the edge-runtime-cuda stage—either run the
distro's cert update/install command (e.g., install ca-certificates and
update-ca-certificates) inside the edge-runtime-cuda stage or copy the
certificate store from edge-runtime-base (e.g., COPY --from=edge-runtime-base
/etc/ssl/certs /etc/ssl/certs and related files); update the Dockerfile near the
edge-runtime-cuda stage (the lines referencing FROM
nvidia/cuda:11.8.0-cudnn8-runtime-ubuntu22.04 and COPY --from=edge-runtime-base
...) to include one of these steps so TLS can find CA certificates at runtime.

@nyannyacha nyannyacha requested a review from a team February 23, 2026 01:13
@nyannyacha nyannyacha merged commit 9f0294e into main Feb 23, 2026
1 check passed
@nyannyacha nyannyacha deleted the ny/dockerfile-cert branch February 23, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edge‑runtime Dockerfile lacks CA certificates – hyper‑rustls panics with “no CA certificates found”

2 participants