Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/base/test_cases/commonjs-require-esm/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
const esm = require("./message.mjs");

if (esm.message !== "cjs require esm ok") {
throw new Error(`unexpected ESM value: ${esm.message}`);
}

Deno.serve(() => new Response(esm.message));
1 change: 1 addition & 0 deletions crates/base/test_cases/commonjs-require-esm/message.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const message = "cjs require esm ok";
4 changes: 4 additions & 0 deletions crates/base/test_cases/commonjs-require-esm/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"workspaces": [],
"type": "commonjs"
}
19 changes: 19 additions & 0 deletions crates/base/tests/integration_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3253,6 +3253,25 @@ async fn test_commonjs() {
);
}

#[tokio::test]
#[serial]
async fn test_commonjs_require_esm() {
integration_test!(
"./test_cases/main",
NON_SECURE_PORT,
"commonjs-require-esm",
None,
None,
None,
(|resp| async {
let resp = resp.unwrap();
assert_eq!(resp.status().as_u16(), 200);
assert_eq!(resp.text().await.unwrap().as_str(), "cjs require esm ok");
}),
TerminationToken::new()
);
}

#[tokio::test]
#[serial]
async fn test_commonjs_no_type_field_in_package_json() {
Expand Down
32 changes: 16 additions & 16 deletions crates/deno_facade/module_loader/standalone.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ use deno::PermissionsContainer;
use deno_config::workspace::MappedResolution;
use deno_config::workspace::ResolverWorkspaceJsrPackage;
use deno_config::workspace::WorkspaceResolver;
use deno_core::error::generic_error;
use deno_core::error::type_error;
use deno_core::error::AnyError;
use deno_core::futures::FutureExt;
Expand Down Expand Up @@ -148,28 +147,29 @@ pub struct EmbeddedModuleLoader {
pub(crate) include_source_map: bool,
}

fn resolve_standalone_referrer(
referrer: &str,
root_path: &Path,
) -> Result<ModuleSpecifier, AnyError> {
if referrer == "." {
return Ok(deno_core::resolve_path(".", root_path)?);
}

ModuleSpecifier::parse(referrer).map_err(|err| {
type_error(format!("Referrer uses invalid specifier: {}", err))
})
}

impl ModuleLoader for EmbeddedModuleLoader {
#[instrument(level = "debug", skip(self))]
fn resolve(
&self,
specifier: &str,
referrer: &str,
kind: ResolutionKind,
_kind: ResolutionKind,
) -> Result<ModuleSpecifier, AnyError> {
let referrer = if referrer == "." {
if kind != ResolutionKind::MainModule {
return Err(generic_error(format!(
"Expected to resolve main module, got {:?} instead.",
kind
)));
}

deno_core::resolve_path(".", &self.shared.root_path)?
} else {
ModuleSpecifier::parse(referrer).map_err(|err| {
type_error(format!("Referrer uses invalid specifier: {}", err))
})?
};
let referrer =
resolve_standalone_referrer(referrer, &self.shared.root_path)?;
let referrer_kind = if self
.shared
.cjs_tracker
Expand Down