Skip to content

Conversation

@iambriccardo
Copy link
Contributor

@iambriccardo iambriccardo commented Nov 5, 2025

This PR implements the possibility to create an experimental docker image, this way we are able to release images and clearly mark them as experimental. This applies for images that come from branches that are not main.

@coveralls
Copy link

coveralls commented Nov 5, 2025

Pull Request Test Coverage Report for Build 19096110303

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 68 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 82.367%

Files with Coverage Reduction New Missed Lines %
etl/src/workers/table_sync.rs 2 77.41%
etl/src/pipeline.rs 4 80.14%
etl-postgres/src/tokio/test_utils.rs 6 89.45%
etl/src/replication/client.rs 56 79.83%
Totals Coverage Status
Change from base Build 19095625550: 0.0%
Covered Lines: 16060
Relevant Lines: 19498

💛 - Coveralls

@iambriccardo iambriccardo marked this pull request as ready for review November 5, 2025 09:59
@iambriccardo iambriccardo requested a review from a team as a code owner November 5, 2025 09:59
@iambriccardo iambriccardo merged commit 2e74912 into main Nov 5, 2025
27 of 34 checks passed
@iambriccardo iambriccardo deleted the update-docker branch November 5, 2025 09:59
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +66 to +69
CURRENT_SHA=$(git rev-parse HEAD)
# Get the main branch SHA
MAIN_SHA=$(git rev-parse origin/main)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fetch main ref before comparing SHAs

The experimental gate relies on git rev-parse origin/main to detect builds from the default branch, but the preceding checkout only fetches the requested ref. On a workflow_dispatch run for a feature branch, the remote reference origin/main is not guaranteed to exist, so git rev-parse origin/main can fail with “unknown revision” and abort the job even when the ref is valid. Fetch origin main (or compare against refs/remotes/origin/main after an explicit fetch) before running this check so experimental builds don’t fail immediately.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants