Skip to content

Conversation

@iambriccardo
Copy link
Contributor

@iambriccardo iambriccardo commented Nov 19, 2025

This PR improves the handling of configurations with the following changes:

  • Adds support for yaml, yml and json configs.
  • Adds a APP_CONFIG_DIR environment variable to allow for custom path configuration for the configuration.
  • Correctly names json configs with the .json extension when creating the config map for the replicator.
  • Remove the useless embedding of configuration objects from the repository into the docker images.
  • Adds tests for the configuration loading.

@coveralls
Copy link

coveralls commented Nov 19, 2025

Pull Request Test Coverage Report for Build 19532593692

Details

  • 170 of 205 (82.93%) changed or added relevant lines in 6 files are covered.
  • 27 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 82.529%

Changes Missing Coverage Covered Lines Changed/Added Lines %
etl-api/src/routes/pipelines.rs 0 1 0.0%
etl-replicator/src/config.rs 0 1 0.0%
etl-api/src/k8s/http.rs 16 20 80.0%
etl-api/src/main.rs 0 4 0.0%
etl-config/src/load.rs 137 162 84.57%
Files with Coverage Reduction New Missed Lines %
etl-api/src/k8s/http.rs 1 90.89%
etl/src/workers/table_sync.rs 2 77.41%
etl-postgres/src/tokio/test_utils.rs 4 89.97%
etl/src/replication/client.rs 20 85.83%
Totals Coverage Status
Change from base Build 19500901379: 0.02%
Covered Lines: 16354
Relevant Lines: 19816

💛 - Coveralls

@iambriccardo iambriccardo marked this pull request as ready for review November 20, 2025 10:25
@iambriccardo iambriccardo requested a review from a team as a code owner November 20, 2025 10:25
@iambriccardo iambriccardo merged commit 9fbcc4f into main Nov 20, 2025
11 checks passed
@iambriccardo iambriccardo deleted the improve-config branch November 20, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants