Skip to content

fix(tests): Fix flaky test #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iambriccardo merged 1 commit into from
Nov 24, 2025
Merged

fix(tests): Fix flaky test #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions etl-postgres/src/tokio/test_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use std::num::NonZeroI32;

use etl_config::shared::{IntoConnectOptions, PgConnectionConfig};
use tokio::runtime::Handle;
use tokio_postgres::types::{ToSql, Type};
use tokio_postgres::types::{FromSql, ToSql, Type};
use tokio_postgres::{Client, GenericClient, NoTls, Transaction};
use tracing::info;

Expand Down Expand Up @@ -240,7 +240,7 @@ impl<G: GenericClient> PgDatabase<G> {
&self,
table_name: TableName,
columns: &[&str],
values: &[&(dyn tokio_postgres::types::ToSql + Sync)],
values: &[&(dyn ToSql + Sync)],
) -> Result<u64, tokio_postgres::Error> {
let columns_str = columns.join(", ");
let placeholders: Vec<String> = (1..=values.len()).map(|i| format!("${i}")).collect();
Expand Down Expand Up @@ -362,7 +362,7 @@ impl<G: GenericClient> PgDatabase<G> {
where_clause: Option<&str>,
) -> Result<Vec<T>, tokio_postgres::Error>
where
T: for<'a> tokio_postgres::types::FromSql<'a>,
T: for<'a> FromSql<'a>,
{
let where_str = where_clause.map_or(String::new(), |w| format!("where {w}"));
let query = format!(
Expand Down
6 changes: 4 additions & 2 deletions etl/tests/pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,9 +985,11 @@ async fn table_without_primary_key_is_errored() {
assert_eq!(err.kinds().len(), 1);
assert_eq!(err.kinds()[0], ErrorKind::SourceSchemaError);

// We expect no events to be saved.
// We expect the insert events to not be saved.
let events = destination.get_events().await;
assert!(events.is_empty());
let grouped_events = group_events_by_type_and_table_id(&events);
let insert_events = grouped_events.get(&(EventType::Insert, table_id));
assert!(insert_events.is_none());
}

#[tokio::test(flavor = "multi_thread")]
Expand Down