-
-
Notifications
You must be signed in to change notification settings - Fork 137
feat(api): Implement validation endpoints #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iambriccardo
merged 20 commits into
main
from
riccardobusetti/etl-468-implement-validation-endpoint
Jan 6, 2026
Merged
feat(api): Implement validation endpoints #520
iambriccardo
merged 20 commits into
main
from
riccardobusetti/etl-468-implement-validation-endpoint
Jan 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
commented
Jan 2, 2026
| const MAX_POOL_CONNECTIONS: u32 = 1; | ||
|
|
||
| /// Connects to the source database with the specified configuration and default connection pool size. | ||
| pub async fn connect_to_source_database_with_defaults( |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved here.
Pull Request Test Coverage Report for Build 20738127653Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
srcCraftsman
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces validation endpoints for destinations, pipelines, and their combined configuration, with the goal of making it easier for users to verify that all required preconditions are satisfied before a pipeline is created or executed.
The validation mechanism is implemented through three new endpoints, each responsible for validating a pipeline, a destination, or both together. These endpoints are intended to be called prior to resource creation, allowing clients to determine upfront whether a configuration is viable and whether all prerequisites are met. The system is structured to support incremental validation steps, making it straightforward to extend with additional checks over time.
The design follows the principle that the replicator itself should not perform validation, and should instead fail fast when encountering invalid configurations. This keeps the replicator code simpler and avoids negatively impacting startup performance, which would otherwise be affected by executing potentially expensive validation logic during initialization