Skip to content

Conversation

@iambriccardo
Copy link
Contributor

@iambriccardo iambriccardo commented Jan 28, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Disabled lock timeout in ETL replication operations, allowing long-running operations to complete without timeout interruptions on busy databases.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Updated ETL replication connection timeout configuration by disabling the lock_timeout (changed from 30,000 to 0 milliseconds) to allow long-running operations during replication slot creation. Added documentation explaining that CREATE_REPLICATION_SLOT must wait for in-progress transactions to complete, which can take extended time on busy databases.

Changes

Cohort / File(s) Summary
Replication Configuration & Documentation
etl-config/src/shared/connection.rs
Changed ETL_REPLICATION_OPTIONS lock_timeout from 30000 to 0; expanded documentation comments to explain the disable rationale; updated corresponding test assertions to reflect the new timeout value

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: disabling lock_timeout on the replication connection by setting it to 0 instead of 30000.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@iambriccardo iambriccardo marked this pull request as ready for review January 28, 2026 09:59
@iambriccardo iambriccardo requested a review from a team as a code owner January 28, 2026 09:59
@coveralls
Copy link

coveralls commented Jan 28, 2026

Pull Request Test Coverage Report for Build 21433595385

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 40 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.009%) to 81.228%

Files with Coverage Reduction New Missed Lines %
etl-postgres/src/tokio/test_utils.rs 4 81.97%
etl/src/workers/table_sync.rs 4 89.62%
etl/src/replication/apply.rs 12 83.51%
etl/src/replication/client.rs 20 85.43%
Totals Coverage Status
Change from base Build 21402452125: -0.009%
Covered Lines: 17386
Relevant Lines: 21404

💛 - Coveralls

@iambriccardo iambriccardo merged commit 46166dd into main Jan 28, 2026
12 of 13 checks passed
@iambriccardo iambriccardo deleted the update-params branch January 28, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants