Skip to content

ref(config): Change default of memory backpressure#610

Merged
iambriccardo merged 1 commit intomainfrom
change-default-memory
Feb 24, 2026
Merged

ref(config): Change default of memory backpressure#610
iambriccardo merged 1 commit intomainfrom
change-default-memory

Conversation

@iambriccardo
Copy link
Contributor

No description provided.

@iambriccardo iambriccardo marked this pull request as ready for review February 24, 2026 09:21
@iambriccardo iambriccardo requested a review from a team as a code owner February 24, 2026 09:21
@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Cache: Disabled due to Reviews > Disable Cache setting

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ee8a088 and 28d1432.

📒 Files selected for processing (2)
  • etl-api/src/configs/pipeline.rs
  • etl-config/src/shared/pipeline.rs

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Improved consistency of configuration default value handling for memory backpressure settings across pipeline configurations.

Walkthrough

The changes standardize the default value handling for memory_backpressure configuration fields across two codebase modules. A new helper function default_memory_backpressure() is introduced that returns Some(MemoryBackpressureConfig::default()). The serde attributes on four configuration structs (FullApiPipelineConfig, StoredPipelineConfig, PipelineConfig, and PipelineConfigWithoutSecrets) are updated from generic #[serde(default)] to explicitly use the custom default function via #[serde(default = "default_memory_backpressure")]. This provides consistent and explicit control over default initialization behavior when these fields are omitted during deserialization.


Comment @coderabbitai help to get the list of available commands and usage tips.

@iambriccardo iambriccardo merged commit ad38b97 into main Feb 24, 2026
12 checks passed
@iambriccardo iambriccardo deleted the change-default-memory branch February 24, 2026 09:32
@coveralls
Copy link

Coverage Status

coverage: 67.984% (-0.01%) from 67.997%
when pulling 28d1432 on change-default-memory
into ee8a088 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants