Harden CI workflow against untrusted pull requests#665
Draft
Conversation
jmqd
force-pushed
the
jm/ci-security-hardening
branch
6 times, most recently
from
66a0bdf to
902346e
Compare
- Add `ci-approved` label check to `test-full` so external PRs cannot run tests with secrets access without maintainer approval. - Add `approve-ci.yml` workflow (`pull_request_target`) that auto-adds the `ci-approved` label for repo collaborators. - Remove unused `id-token: write` permission from `test-full`.
jmqd
force-pushed
the
jm/ci-security-hardening
branch
from
902346e to
6433185
Compare
jmqd
added
dependencies
|
coverage: 78.364% (-0.02%) from 78.38% — jm/ci-security-hardening into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci-approvedlabel check totest-fullso external PRs cannotrun tests with secrets access without maintainer approval.
approve-ci.ymlworkflow (pull_request_target) that auto-addsthe
ci-approvedlabel for repo collaborators.id-token: writepermission fromtest-full.