feat(api: Improve deletion semantics for endpoints#669
Merged
iambriccardo merged 5 commits intomainfrom Apr 20, 2026
Merged
Conversation
farazdagi
reviewed
Apr 17, 2026
farazdagi
reviewed
Apr 17, 2026
farazdagi
reviewed
Apr 17, 2026
farazdagi
reviewed
Apr 17, 2026
farazdagi
reviewed
Apr 17, 2026
bnjjj
reviewed
Apr 17, 2026
# Conflicts: # etl-api/src/db/pipelines.rs
farazdagi
approved these changes
Apr 20, 2026
Contributor
farazdagi
left a comment
There was a problem hiding this comment.
Thank you for looking into commented items. lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve deletion behavior across the ETL API so destructive endpoints behave more predictably when pipelines are still active, and so source-side ETL state is cleaned up more deliberately during pipeline and tenant teardown.
What changed
409 Conflictinstead of attempting deletes while a replicator is still active in Kubernetes.Behavior changes
DELETE /pipelines/{id}now rejects deletion for active pipelines.DELETE /destinations/{destination_id}/pipelines/{pipeline_id}now rejects deletion for active pipelines.DELETE /sources/{id}andDELETE /destinations/{id}now return conflicts when the resource is still in use by pipelines.DELETE /tenants/{tenant_id}now performs best-effort source cleanup first, then deletes the tenant row and lets Postgres cascade the tenant-owned API rows.Tests
Notes
This PR is primarily about deletion semantics and cleanup behavior. Most of the code churn is in route-level orchestration, shared deletion helpers, and the corresponding test coverage.