Skip to content

feat(core): Improve security around logging and error monitoring#720

Merged
iambriccardo merged 7 commits intomainfrom
make-sentry-more-secure
May 8, 2026
Merged

feat(core): Improve security around logging and error monitoring#720
iambriccardo merged 7 commits intomainfrom
make-sentry-more-secure

Conversation

@iambriccardo
Copy link
Copy Markdown
Contributor

@iambriccardo iambriccardo commented May 7, 2026

Summary

  • Harden Sentry handling for sensitive API endpoints by scrubbing request data, response/body-like context, query strings, cookies, headers, and disabling trace sampling for those routes.
  • Reduce sensitive logging across ETL and destinations by avoiding passwords, row/cell values, and request/response bodies while keeping useful metadata such as table names, counts, SQL context, and phase types.
  • Standardize error handling so wrapped errors use the source chain instead of embedding error strings in messages/details where possible.
  • Keep etl-api database/Postgres errors from leaking through HTTP responses, while preserving internal error chains for debugging.
  • Normalize observability conventions in AGENTS.md, including error = %... log fields, lowercase log prose, uppercase error messages, and table_replication_phase_type naming.

@iambriccardo iambriccardo changed the title make sentry more secure feat(core): Improve security around logging and error monitoring May 7, 2026
Comment thread etl-destinations/src/ducklake/maintenance.rs
@iambriccardo iambriccardo marked this pull request as ready for review May 8, 2026 06:49
@iambriccardo iambriccardo requested a review from a team as a code owner May 8, 2026 06:49
Copy link
Copy Markdown
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iambriccardo iambriccardo enabled auto-merge (squash) May 8, 2026 07:34
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 76.397% (-0.1%) from 76.496% — make-sentry-more-secure into main

@iambriccardo iambriccardo merged commit 5d69883 into main May 8, 2026
14 checks passed
@iambriccardo iambriccardo deleted the make-sentry-more-secure branch May 8, 2026 07:37
@florianschulte
Copy link
Copy Markdown

Incredible ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants