feat(connection): Add hostaddr support#722
Merged
Merged
Conversation
jmqd
approved these changes
May 8, 2026
Contributor
jmqd
left a comment
jmqd
left a comment
There was a problem hiding this comment.
LGTM modulo the red CI that requires cargo insta test --accept
|
coverage: 76.494% (+0.02%) from 76.473% — add-ipv6-support into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
hostaddrsupport to Postgres connection configuration, allowing ETL to dial a specific IP address while preserving the configuredhostfor TLS hostname verification.Due to a limitation in sqlx, which doesn't allow to set
hostandhostaddrseparately, we have to perform averify-casetting instead ofverify-fullsince we have to omit the hostname verification.