Skip to content

Improve clickhouse validation hygiene#769

Merged
jmqd merged 2 commits into
mainfrom
jm/clickhouse-validation-hygiene
May 27, 2026
Merged

Improve clickhouse validation hygiene#769
jmqd merged 2 commits into
mainfrom
jm/clickhouse-validation-hygiene

Conversation

@jmqd
Copy link
Copy Markdown
Contributor

@jmqd jmqd commented May 27, 2026

  • The ClickHouse validator distinguishes five failure modes (URL invalid, user empty, database empty, connection failed, database not found) where today everything lumps into one generic "Connection Failed" message.
  • The validator rejects non-HTTPS URLs.
  • Added ClickHouseClient::new_without_database and ClickHouseClient::database_exists(name) so the validator can probe connectivity and database existence independently -- mirrors BigQuery's new_with_key / dataset_exists pair.

Closes ETL-634.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 72.894% (+0.03%) from 72.868% — jm/clickhouse-validation-hygiene into main

@jmqd jmqd marked this pull request as ready for review May 27, 2026 05:56
@jmqd jmqd requested a review from a team as a code owner May 27, 2026 05:56
@jmqd jmqd merged commit b6f7b96 into main May 27, 2026
18 checks passed
@jmqd jmqd deleted the jm/clickhouse-validation-hygiene branch May 27, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants