ref(bigquery): Improve BigQuery encoding and logs#878
Draft
iambriccardo wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes duplicated and overly verbose logging, and reworks BigQuery row encoding for correctness and efficiency.
Logging
info!logs during pipeline shutdown, replication slot lookup/deletion, and table sync worker startup/state persistence todebug!, since a higher-level summary is already logged elsewhere.BigQuery row encoding
BigQueryTableRownow stores only its already-encoded Protocol Buffer bytes (Vec<u8>) instead of keeping both the source cells and a separate encoded-bytes cache alive. Encoding happens once, up front, intry_from_tagged_cells, andencoded_len/encode_rawjust read the already-encoded buffer. Previously,gcp-bigquery-clientcallingencoded_len()for batch budgeting and thenencode_to_vec()(which callsencoded_len()again beforeencode_raw()) caused every row's date/numeric/UUID/JSON fields to be formatted up to 3 times.CellNonOptional/ArrayCellNonOptionalfrometl::data, which existed solely to give BigQuery a type-level guarantee that arrays contain no NULL elements. BigQuery is now the only destination that cared about this, so the check moved to a runtime validation (validate_array_cell_for_bigquery) that rejects NULL array elements withNullValuesNotSupportedInArrayInDestination, rather than duplicatingCell/ArrayCellin a parallel non-nullable enum.