fix: update prefix to include version before catalog name #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, the version needs to come before the
prefixwhich is calledcatalogNamewhen instantiating theIcebergRestCatalogWhat is the current behavior?
current behavior creates the path with prefix first
{prefix}/v1/namespaceWhat is the new behavior?
new behavior creates the path with the prefix after the version e.g.
v1/{prefix}/namespace. I thought it was easier to just include thev1always into the prefix. I initially ran into some issues when having it as/v1in thebuildUrl()theconst url = new URL(path, baseUrl)if thepathhas a leading/it will replace everything after the TLD. This is why I left it asv1Additional context
Iceberg REST Catalog OpenAPI
