Skip to content

Conversation

@TylerHillery
Copy link
Contributor

@TylerHillery TylerHillery commented Nov 21, 2025

What kind of change does this PR introduce?

Bug fix, the version needs to come before the prefix which is called catalogName when instantiating the IcebergRestCatalog

What is the current behavior?

current behavior creates the path with prefix first {prefix}/v1/namespace

What is the new behavior?

new behavior creates the path with the prefix after the version e.g. v1/{prefix}/namespace. I thought it was easier to just include the v1 always into the prefix. I initially ran into some issues when having it as /v1 in the buildUrl() the const url = new URL(path, baseUrl) if the path has a leading / it will replace everything after the TLD. This is why I left it as v1

Additional context

Iceberg REST Catalog OpenAPI
image

@TylerHillery TylerHillery requested review from a team as code owners November 21, 2025 00:12
@TylerHillery TylerHillery marked this pull request as draft November 21, 2025 00:21
@TylerHillery TylerHillery marked this pull request as ready for review November 21, 2025 00:44
@mandarini mandarini merged commit db4f2ca into main Nov 21, 2025
3 checks passed
@mandarini mandarini deleted the tyler/fix/list-namespaces branch November 21, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants