fix: write to database more frequently during manual sync#20
Merged
Conversation
kevcodez
reviewed
Sep 30, 2024
ecktoteckto
force-pushed
the
fix/fix-manual-sync-timeouts
branch
from
September 30, 2024 14:29
0432612 to
7d5e1d5
Compare
kevcodez
approved these changes
Sep 30, 2024
|
🎉 This PR is included in version 1.5.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write to database after each (pagination) request to Orb-API instead of at the very end.
Context:
When manually syncing a larger number of entities, we regularly run into Gateway Timeouts (504). Although most time is simply spent on requesting the Orb-API (and not on processing the returned data) we now write to the database more frequently instead of collecting thousands of entities before updating the database.
In addition:
We log the time spent on requesting the Orb-API and writing to the database