fix: forward types in pgTypeToGoType array fallback so enum arrays resolve to []string#1074
Merged
avallete merged 1 commit intosupabase:masterfrom Apr 30, 2026
Merged
Conversation
avallete
approved these changes
Apr 30, 2026
Member
avallete
left a comment
There was a problem hiding this comment.
Thank's for your contribution !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgTypeToGoTyperecurses through the array branch with only(pgType, nullable), so the third argument defaults to[]. Inner enums and composites then can't be resolved and fall through tointerface{}, even though the same enum resolves tostringoutside an array.This forwards
typesto the recursive call.Added
test/server/templates/go.test.tswith three cases: non-nullable array of enum should be[]string, nullable array of enum should be[]*string, and plaintext[]continues to be[]string. Callsapplywith mockGeneratorMetadataso the test runs without Docker.Closes #1073