fix: ErlSysMon initialization #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Our application supervision tree adds ErlSysMon like this:
[
ErlSysMon,
...
]
This translates to {ErlSysMon, []} so ErlSysMon.start_link([]) was being
called effectively making system_monitor not track anything
chasers
approved these changes
Jun 3, 2025
Member
|
🎉 This PR is included in version 2.36.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix
ErlSysMoninitialization.Our application supervision tree adds ErlSysMon like this:
This translates to
{ErlSysMon, []}soErlSysMon.start_link([])was being called effectively making system_monitor not track anything.I also tested locally calling
:erlang.system_monitor()which just returns the current configuration. Previously it was returning:undefinedbecause nothing was set.What is the current behavior?
No erlang system monitor messages
What is the new behavior?
System monitor messages are being logged
Additional context