fix: bump replication connection backoff min and max#1762
Open
fix: bump replication connection backoff min and max#1762
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the tenant replication recovery retry behavior to be less aggressive by increasing the maximum exponential backoff, keeping retry logic intact while reducing churn during extended outages.
Changes:
- Increase replication recovery backoff max from 15 seconds to 5 minutes in
Realtime.Tenants.Connect. - Update the corresponding backoff configuration test assertion.
- Add dashboard basic-auth credentials to
make devandmake dev.orangecommands (to satisfy runtime config requirements).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/realtime/tenants/connect.ex | Bumps replication recovery backoff_max to 5 minutes. |
| test/realtime/tenants/connect_test.exs | Updates backoff max assertion to match new configuration. |
| Makefile | Adds DASHBOARD_USER/DASHBOARD_PASSWORD env vars to dev server targets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
filipecabaco
approved these changes
Mar 19, 2026
edgurgel
force-pushed
the
fix/bump-replication-connection-backoff-max
branch
from
ce4ae04 to
af1b875
Compare
edgurgel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We can be less aggressive with the backoff