Merged
Conversation
|
Coverage is 91.784% — fix/validate-track-payload into main. No base build found for |
edgurgel
reviewed
Apr 14, 2026
filipecabaco
force-pushed
the
fix/validate-track-payload
branch
2 times, most recently
from
851fe91 to
f0f9c18
Compare
filipecabaco
force-pushed
the
fix/validate-track-payload
branch
from
f0f9c18 to
66eccc8
Compare
edgurgel
reviewed
Apr 18, 2026
| shutdown_response(socket, "Track message size exceeded") | ||
|
|
||
| {:error, :invalid_payload} -> | ||
| log_error(socket, "InvalidPresencePayload", :invalid_payload) |
Member
There was a problem hiding this comment.
Oh we need to include this error in the README: https://github.com/supabase/realtime#error-operational-codes
edgurgel
reviewed
Apr 18, 2026
|
|
||
| {:error, :invalid_payload} -> | ||
| log_error(socket, "InvalidPresencePayload", :invalid_payload) | ||
| {:reply, {:error, %{reason: "Presence track payload must be a map"}}, socket} |
Member
There was a problem hiding this comment.
Any idea what our realtime-js library will see when this error happens? I don't remember how we surface such error on track
Member
Author
There was a problem hiding this comment.
not sure either will try to verify but overall errors in the clients lib ain't the best from what I recall
edgurgel
approved these changes
Apr 18, 2026
Member
edgurgel
left a comment
edgurgel
left a comment
There was a problem hiding this comment.
Added a question and a small doc change but other than that LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Properly handle track payload