fix: properly clean up subscriptions when oids changed#1813
Merged
Conversation
filipecabaco
approved these changes
Apr 15, 2026
|
coverage: 91.885% (+0.005%) from 91.88% — fix/subscription-manager-cleanup into main |
|
🎉 This PR is included in version 2.83.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We were calling
Process.demonitor/2but we were not cleaning up the tables when subscriptions were re-set.This way we kept trying to check for these pids but when a node was gone we would still try to contact them on SubscriptionChecker