Skip to content

fix: Subscriptions.create transaction should timeout early#1821

Merged
edgurgel merged 1 commit intomainfrom
fix/decrease-subscription-timeout
Apr 20, 2026
Merged

fix: Subscriptions.create transaction should timeout early#1821
edgurgel merged 1 commit intomainfrom
fix/decrease-subscription-timeout

Conversation

@edgurgel
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

The RPC timeout is currently sitting at 15s (also the default Postgrex.transaction/2,3 timeout)

case GenRpc.call(node(conn), __MODULE__, :create_subscription, args, timeout: 15_000, tenant_id: tenant) do

10 seconds should be plenty of time to create subscriptions

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage is 91.7%fix/decrease-subscription-timeout into main. No base build found for main.

@edgurgel edgurgel merged commit 45f02a9 into main Apr 20, 2026
15 of 18 checks passed
@edgurgel edgurgel deleted the fix/decrease-subscription-timeout branch April 20, 2026 10:07
@realtime-release-bot
Copy link
Copy Markdown

🎉 This PR is included in version 2.86.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants