fix(dashboard): tenant db connect dns ipv6#1910
Merged
Merged
Conversation
Small fix to correctly build a postgres url. Initially it was relying on `:socket_options` but it needs to verify the format as well.
edgurgel
approved these changes
May 25, 2026
|
Coverage is 91.28% — lp-fix-tenant-db-conn into main. No base build found for |
|
🎉 This PR is included in version 2.98.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to correctly build a postgres url in Tenant Migrations page.
Initially it was relying on
:socket_optionsbut it needs to verify the format as well as shown in test"builds a valid URL for DNS hostnames resolved over IPv6"