feat: default messages partition#1940
Closed
leandrocp wants to merge 3 commits into
Closed
Conversation
We still have edge cases where realtime.send would raise ErrorSendingBroadcastMessage because of missing partitions, even with health check creating them (#1939) for example when the function is called before a WS conn or before health check. This is a proposal to close that gap by using a default partition which works as a catch-all in case a partition doesn't exist yet, again rare cases but still possible.
|
Coverage is 91.387% — feat/lp-messages-default-partition into main. No base build found for |
Contributor
Author
|
After some discussion let's move to a warning approach instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still have edge cases where realtime.send would raise ErrorSendingBroadcastMessage because of missing partitions, even with health check creating them (#1939) for example when the function is called before a WS conn or before health check.
This is a proposal to close that gap by using a default partition which works as a catch-all in case a partition doesn't exist yet, again rare cases but still possible.
Fixes REAL-319
Fixes REAL-500
Fixes REAL-848