fix: gracefully ignore missing tenant when cleaning up iceberg resources#1223
Merged
itslenny merged 4 commits intoJul 9, 2026
Merged
Conversation
Coverage Report for CI Build 29057268713Coverage increased (+0.04%) to 79.376%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
Member
|
Can we add a test to seal the behavior so that we don't change by mistake later? |
itslenny
force-pushed
the
lenny/delete-iceberg-resources-with-missing-tenant
branch
from
3e85f41 to
5a71ce5
Compare
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
lenny/delete-iceberg-resources-with-missing-tenant
branch
from
3b2d842 to
69a11da
Compare
ferhatelmas
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
If the tenant is missing when
DeleteIcebergResourcesruns the entire job fails and resources are not cleaned upWhat is the new behavior?
Ignore missing tenant in multitenant mode and still clean up iceberg resources and multitenant db entries