fix: correct boolean check in doesSchemaExists - #968
Merged
fenos merged 1 commit intoApr 6, 2026
Conversation
fenos
approved these changes
Apr 6, 2026
Contributor
|
Great catch @oniani1! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #928
doesSchemaExistscompares the result ofSELECT EXISTS(...)with the string'true', but thepgdriver returns a JavaScript boolean. Sotrue === 'true'is alwaysfalse, meaning the function always reports the schema doesn't exist.This causes the migration to always run
CREATE SCHEMA IF NOT EXISTS storage, which fails for self-hosted setups where the DB user has permissions within the storage schema but notCREATEon the database itself.The fix aligns with how
doesTableExist(same file, line 794) already handles the check -- just using the boolean value directly.