fix: register Watt close handler#1009
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project to Platformatic/Watt 3.52.0 and integrates a Watt/Platformatic-driven shutdown path by registering a close handler via @platformatic/globals, aiming to eliminate the “missing close handler” shutdown warning while keeping Watt optional.
Changes:
- Bump Platformatic/Watt-related dependencies and the
watt.jsonschema to3.52.0. - Add a Platformatic/Watt
closeevent listener that triggers the existing shutdown flow (via a new exportedclose()). - Add
.npmrcto ensurepackage-lock.jsonis generated/kept.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| watt.json | Updates the Platformatic schema reference to 3.52.0. |
| src/start/server.ts | Registers a Platformatic/Watt close handler and adds an exported close() that triggers shutdown. |
| package.json | Upgrades Platformatic/Watt dependencies and adds @platformatic/globals. |
| package-lock.json | Locks dependency upgrades and newly added package metadata. |
| .npmrc | Forces package-lock generation/usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 24456512436Coverage remained the same at 82.476%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
Summary
Verification