Skip to content

chore: pin npm#1019

Merged
ferhatelmas merged 1 commit intomasterfrom
ferhat/pin-npm
Apr 14, 2026
Merged

chore: pin npm#1019
ferhatelmas merged 1 commit intomasterfrom
ferhat/pin-npm

Conversation

@ferhatelmas
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

chore

What is the current behavior?

npm version isn't pinned.

What is the new behavior?

npm is pinned across every usage.

Additional context

It's needed because package lock format can change and fail later on.

@ferhatelmas ferhatelmas requested a review from a team as a code owner April 14, 2026 12:03
Copilot AI review requested due to automatic review settings April 14, 2026 12:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make npm version usage deterministic across the repo to prevent future package-lock.json format drift and CI failures by pinning npm consistently.

Changes:

  • Adds packageManager: "npm@11.12.1" and tightens engines to specify supported Node/npm ranges.
  • Regenerates package-lock.json under the pinned npm version (plus updates root metadata like packageManager/engines).
  • Updates GitHub Actions workflows to use a new composite action that sets up Node and enforces an exact npm version.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Pins npm via packageManager and adds Node/npm engine constraints.
package-lock.json Updates lockfile metadata/content to match the pinned npm environment.
.github/workflows/ci.yml Switches CI jobs to use the shared Node+npm setup action.
.github/workflows/docs.yml Switches docs workflow to use the shared Node+npm setup action.
.github/workflows/release.yml Switches release workflow to use the shared Node+npm setup action.
.github/actions/setup-node-npm/action.yml Introduces a composite action to set up Node and pin npm before running npm commands.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment thread package.json Outdated
Comment thread .github/actions/setup-node-npm/action.yml Outdated
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 14, 2026

Coverage Report for CI Build 24398781747

Coverage increased (+0.001%) to 82.423%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 33967
Covered Lines: 30482
Line Coverage: 89.74%
Relevant Branches: 7462
Covered Branches: 3665
Branch Coverage: 49.12%
Branches in Coverage %: Yes
Coverage Strength: 345.22 hits per line

💛 - Coveralls

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ferhatelmas ferhatelmas merged commit 9fc93ca into master Apr 14, 2026
11 checks passed
@ferhatelmas ferhatelmas deleted the ferhat/pin-npm branch April 14, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants