Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes an unused generic promise memoization helper from the migrations subsystem and replaces its only usage with a purpose-built cache for migration file loading.
Changes:
- Deleted
memoizePromiseutility and its (non-covering) tests. - Implemented a directory-keyed in-module cache for
loadMigrationFiles, including cache invalidation on rejection. - Simplified
lastLocalMigrationName()logic (explicit empty-migrations handling, and clearer “freeze at” lookup).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/internal/database/migrations/memoize.ts | Removed unused promise memoization helper. |
| src/internal/database/migrations/memoize.test.ts | Removed tests that reimplemented memoization locally rather than testing the production helper. |
| src/internal/database/migrations/files.ts | Added a focused migration-files cache and adjusted callers to use it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 24467924764Coverage decreased (-0.002%) to 82.471%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
57dd4cd to
c1317a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
chore
What is the current behavior?
There is a generic memoize utility for migration loading but its tests are testing it at all.
What is the new behavior?
It's used in one place, not needed. Drop it and its tests.
Additional context
Indirectly, it drops some any usage as well.