Skip to content

fix: use correct JSON Schema keyword in getSignedURLs response#1024

Merged
ferhatelmas merged 1 commit into
supabase:masterfrom
oniani1:fix/signed-urls-schema-type
Apr 15, 2026
Merged

fix: use correct JSON Schema keyword in getSignedURLs response#1024
ferhatelmas merged 1 commit into
supabase:masterfrom
oniani1:fix/signed-urls-schema-type

Conversation

@oniani1
Copy link
Copy Markdown
Contributor

@oniani1 oniani1 commented Apr 15, 2026

Closes #1023

The error property in the getSignedURLs response schema uses error: as the JSON Schema keyword instead of type:. This isn't a valid JSON Schema keyword, so @fastify/swagger skips it when generating the OpenAPI spec -- the published API has no type info for this field.

The sibling signedURL property in the same object already uses type: ['string', 'null'] correctly. One-word fix to match.

@oniani1 oniani1 requested a review from a team as a code owner April 15, 2026 19:46
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24474844911

Coverage decreased (-3.4%) to 79.064%

Details

  • Coverage decreased (-3.4%) from the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • 4301 coverage regressions across 99 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

4301 previously-covered lines in 99 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
src/internal/database/migrations/migrate.ts 291 52.25%
src/internal/queue/queue.ts 257 10.77%
src/internal/streams/hash-stream.ts 191 26.22%
src/internal/concurrency/async-abort-controller.ts 180 17.11%
src/storage/protocols/iceberg/catalog/reconciler.ts 172 13.38%
src/storage/protocols/iceberg/catalog/rest-catalog-client.ts 161 65.52%
src/internal/database/pool.ts 145 65.05%
src/storage/protocols/iceberg/knex.ts 132 64.65%
src/internal/errors/codes.ts 128 73.79%
src/storage/events/upgrades/sync-catalog-ids.ts 124 10.61%

Coverage Stats

Coverage Status
Relevant Lines: 37897
Covered Lines: 30111
Line Coverage: 79.45%
Relevant Branches: 4026
Covered Branches: 3035
Branch Coverage: 75.38%
Branches in Coverage %: Yes
Coverage Strength: 311.78 hits per line

💛 - Coveralls

@ferhatelmas ferhatelmas merged commit b4a3336 into supabase:master Apr 15, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong JSON Schema keyword in getSignedURLs response schema

3 participants