fix: use correct JSON Schema keyword in getSignedURLs response#1024
Merged
Conversation
Coverage Report for CI Build 24474844911Coverage decreased (-3.4%) to 79.064%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions4301 previously-covered lines in 99 files lost coverage.
Coverage Stats💛 - Coveralls |
ferhatelmas
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1023
The
errorproperty in thegetSignedURLsresponse schema useserror:as the JSON Schema keyword instead oftype:. This isn't a valid JSON Schema keyword, so@fastify/swaggerskips it when generating the OpenAPI spec -- the published API has no type info for this field.The sibling
signedURLproperty in the same object already usestype: ['string', 'null']correctly. One-word fix to match.