fix: fastify synthetic shutdown reply in logger#1028
Merged
ferhatelmas merged 1 commit intomasterfrom Apr 16, 2026
Merged
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
fenos
approved these changes
Apr 16, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a shutdown-time logging crash by making the Fastify response serializer tolerant of Fastify “synthetic” replies that don’t implement getHeaders, preventing logger serialization from throwing during server shutdown (as observed under watt).
Changes:
- Guard
reply.getHeaders()in theresserializer and fall back to an empty header object when unavailable. - Add a Vitest unit test to ensure the
resserializer does not throw whengetHeadersis missing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/internal/monitoring/logger.ts | Adds a safe getHeaders guard before header allowlisting in the response serializer. |
| src/internal/monitoring/logger.test.ts | Adds coverage to validate serializer behavior with synthetic replies lacking getHeaders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ferhatelmas
changed the title
Coverage Report for CI Build 24510222416Coverage decreased (-0.003%) to 82.565%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
What is the current behavior?
Fastify gives a syntatic reply while shutting down which doesn't have
getHeaderson it.What is the new behavior?
Guard it.
Additional context
It's visible under watt.