fix: drop unused database functions#1057
Merged
Merged
Conversation
Coverage Report for CI Build 24909783607Coverage decreased (-0.006%) to 71.577%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
ferhatelmas
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Several of the functions that were dropped in migration 0052 used an incorrect signature resulting in the functions not being dropped
What is the new behavior?
Actually drop these unused functions
The function
search_legacy_v1was not included in 0052, but it should've been as it is not used anywhere and for new projects it is not created because of-- postgres-migrations ignorein migration 0034.Also, renamed migration 56 to have the
00prefix to match others. This should not have any impact it will just make the files sort correctly in the directory.