fix: add matrix into acceptance tests#1062
Open
ferhatelmas wants to merge 1 commit intomasterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Extends the acceptance test runner and CI workflow to run across a local setup matrix (storage backend, database flavor, and tenancy), including support for tenant routing via x-forwarded-host.
Changes:
- Add
forwardedHostto acceptance config and automatically applyx-forwarded-hostto acceptance HTTP/S3/SigV4 requests. - Enhance the managed local acceptance runner to support multitenant provisioning/cleanup and configurable infra restart script.
- Expand the GitHub Actions acceptance workflow into a 3‑axis matrix and upload per-matrix artifacts.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| acceptance/support/sigv4.ts | Adds optional x-forwarded-host to signed chunked S3 requests. |
| acceptance/support/s3.ts | Injects x-forwarded-host via S3 client middleware when configured. |
| acceptance/support/http.ts | Centralizes acceptance header creation and auto-adds x-forwarded-host. |
| acceptance/support/config.ts | Adds forwardedHost to acceptance config (CLI/env support). |
| acceptance/specs/tus.test.ts | Routes TUS fetch/tus-js-client calls through acceptance header helpers. |
| acceptance/specs/rest-object.test.ts | Ensures signed URL fetch includes acceptance headers. |
| acceptance/specs/rest-extended.test.ts | Adds acceptance headers to signed upload fetch requests. |
| acceptance/specs/cdn-render.test.ts | Applies acceptance header helper (optionally with auth token). |
| acceptance/scripts/run-managed-local.ts | Adds tenancy-aware provisioning/cleanup + infra restart script selection. |
| acceptance/README.md | Documents ACCEPTANCE_X_FORWARDED_HOST. |
| .github/workflows/acceptance.yml | Introduces local matrix (backend/db/tenancy) and per-matrix artifacts/env. |
| .env.acceptance.sample | Adds ACCEPTANCE_X_FORWARDED_HOST placeholder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 25016901858Coverage increased (+0.04%) to 71.647%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
ferhatelmas
force-pushed
the
ferhat/acceptance-2
branch
from
71f232a to
e7049e8
Compare
This comment has been minimized.
This comment has been minimized.
ferhatelmas
force-pushed
the
ferhat/acceptance-2
branch
from
e7049e8 to
f6e587f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
ferhat/acceptance-2
branch
from
f6e587f to
16070cf
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
test feat
What is the current behavior?
Acceptance tests run a small smoke profile in a single setup.
What is the new behavior?
Add local setup matrix for backend, db and tenancy.
Additional context
Related to knex and builds on #1060.