fix: range reads for file backend#1087
Merged
ferhatelmas merged 1 commit intomasterfrom May 8, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes HTTP Range request handling in the file-backed storage backend by adding a more permissive and spec-aligned byte range parser (supporting explicit, open-ended, and suffix ranges) and validating invalid ranges with a 416 response.
Changes:
- Replaced ad-hoc Range parsing in
FileBackend.getObject()with a dedicatedparseByteRange()helper that supportsbytes=start-end,bytes=start-, andbytes=-suffixLength. - Added unit tests for file-backend range reads (including invalid range rejection).
- Extended S3 acceptance tests to cover suffix/open-ended ranges and invalid range behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/storage/backend/file.ts | Implements robust byte-range parsing and returns correct 206 metadata/content-range for file backend reads. |
| src/storage/backend/file.test.ts | Adds unit coverage for explicit, open-ended, suffix, capped, and invalid range behaviors. |
| acceptance/specs/s3.test.ts | Adds acceptance assertions for suffix/open-ended Range requests and invalid range (416) responses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 25557465900Coverage increased (+0.2%) to 74.249%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
fix off by one size check in upload part copy while making range optional Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
ferhat/range-file
branch
from
5b5ab18 to
dedfd52
Compare
fenos
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
File backend range header parser assumes both numeric.
Upload part copy requires a range header. It also has off by one error.
What is the new behavior?
Parser is permissive as expected.
Upload part copy a range is optional. Size check is done correctly.