chore: drop stream-buffers in favor of a generator#1101
Merged
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the stream-buffers dependency by rewriting the one test case that needed a “slow-chunking” readable stream to use a native async generator + Readable.from, keeping the same behavioral intent while reducing supply-chain surface area.
Changes:
- Replaced
ReadableStreamBufferusage in the S3 protocol test withReadable.from(async function* ...)and a timed delay between chunks. - Removed
stream-buffersand its type package frompackage.json/package-lock.json.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/s3-protocol.test.ts | Replaces the slow-chunk stream construction with a native generator-based readable stream. |
| package.json | Drops stream-buffers and @types/stream-buffers dependencies. |
| package-lock.json | Removes the corresponding locked dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 25731246483Coverage increased (+0.006%) to 74.378%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
fenos
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
What is the current behavior?
stream-buffers dependency is used for a test to construct a stream that emits slow chunks.
What is the new behavior?
Replace it with a generator that sleeps in between since extended API of the dependency isn't needed.
Additional context
Less dependencies is better.