fix: configurable part size#1116
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an environment-configurable multipart upload partSize for the S3 backend, wiring a new config value through getConfig() into the AWS SDK Upload usage so operators can tune multipart behavior without code changes.
Changes:
- Introduces
storageS3UploadPartSizeconfig (env:STORAGE_S3_UPLOAD_PART_SIZE) with a default (16MiB) and a minimum clamp (5MiB). - Passes the configured
partSizeinto@aws-sdk/lib-storage’sUploadconstructor for multipart uploads. - Updates S3 backend unit tests to assert
partSizeis passed through (default path).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/storage/backend/s3/adapter.ts | Plumbs new config value into AWS multipart Upload partSize. |
| src/storage/backend/s3/adapter.test.ts | Adds assertions that Upload receives partSize (currently only default covered). |
| src/config.ts | Adds storageS3UploadPartSize config parsing with default + minimum clamp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 26215966261Coverage decreased (-0.006%) to 74.98%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
fenos
approved these changes
May 21, 2026
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
No configuration for part size.
What is the new behavior?
Environment configurable part size