feat(migrations): do not use bound parameters#1128
Draft
rafael wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Rafael Chacon <24160+rafael@users.noreply.github.com>
Coverage Report for CI Build 26477286915Coverage increased (+0.01%) to 75.163%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Compatibility change.
What is the current behavior?
The
SELECT set_config(...)batch that runs before tenant migrations (src/internal/database/migrations/migrate.ts) passes its values as bound parameters:Stock PostgreSQL accepts this, but some Multigres doesn't support this (yet) and rejects the query with:
This causes runMigrations to fail at startup against those engines, blocking the integration entirely.
What is the new behavior?
The eight set_config values are now inlined as SQL literals via a small lit() helper that escapes single quotes.
Tests
npm run migration:runpointing against a local multigres cluster and with this fix migrations work.npm run test:integrationand all tests pass.