fix: cut down per request garbage#1202
Merged
Merged
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces per-request garbage by reusing immutable objects and avoiding unnecessary renderer factory allocations in the Storage layer and HTTP storage plugin.
Changes:
- Refactored
Storage.renderer()to use aswitchfor lazy, single-renderer instantiation instead of constructing an object of factories per call. - Reused a singleton
TenantLocationfor non-iceberg requests to avoid per-request allocations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/storage/storage.ts | Avoids per-call renderer factory object creation by switching to an exhaustive switch and assertNever. |
| src/http/plugins/storage.ts | Reuses a singleton TenantLocation instead of allocating a new one for every non-iceberg request. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fenos
approved these changes
Jul 6, 2026
Coverage Report for CI Build 28776554048Coverage decreased (-0.002%) to 78.854%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
What is the current behavior?
Every request creates a new tenant location but it's immutable.
Renderer creates a every version and then discards all except one.
What is the new behavior?
Create a singleton tenant location and shared with all requests.
Use switch in renderer so that it only creates what it needs, nothing else.
Additional context
This reduces per request garbage.