Skip to content

Conversation

@fenos
Copy link
Contributor

@fenos fenos commented Dec 31, 2025

What kind of change does this PR introduce?

Feature

What is the current behavior?

Currently metrics are gathered using the prom-client and exposed to a metric endpoint

What is the new behavior?

  • All metrics are now otel metrics and can be pushed to a 3rd party otel backend
  • We still can optionally expose prometheus metrics in the /metrics endpoint using the otel prom exporter (ENABLE_PROMETHEUS_METRICS)
  • All children spans will now include the tenant.ref attribute from a top level span
  • Revamped grafana dashboard using otel metrics

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20617070357

Details

  • 428 of 943 (45.39%) changed or added relevant lines in 23 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 75.637%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/admin-app.ts 5 6 83.33%
src/internal/database/pool.ts 1 2 50.0%
src/internal/queue/event.ts 1 7 14.29%
src/internal/queue/queue.ts 3 9 33.33%
src/internal/monitoring/system/base-collector.ts 33 45 73.33%
src/internal/monitoring/system/process-start-collector.ts 12 26 46.15%
src/http/plugins/metrics.ts 105 124 84.68%
src/internal/monitoring/system/handles-collector.ts 10 36 27.78%
src/internal/monitoring/system/instrumentation.ts 41 82 50.0%
src/internal/monitoring/system/cpu-collector.ts 3 49 6.12%
Files with Coverage Reduction New Missed Lines %
src/admin-app.ts 1 89.19%
Totals Coverage Status
Change from base Build 20603297633: -0.4%
Covered Lines: 25678
Relevant Lines: 33679

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants