Skip to content

chore: switch into biome and format all md/yml via prettier#877

Merged
ferhatelmas merged 1 commit intomasterfrom
ferhat/format
Feb 26, 2026
Merged

chore: switch into biome and format all md/yml via prettier#877
ferhatelmas merged 1 commit intomasterfrom
ferhat/format

Conversation

@ferhatelmas
Copy link
Member

What kind of change does this PR introduce?

chore

What is the current behavior?

No consistent formatting for all file types.

What is the new behavior?

Use biome for json, jsonc, ts, js.
Use prettier for markdown and yaml. Biome support is coming.

Additional context

Enable formatting for all files. Previously, non-src files weren't formatted.

@ferhatelmas ferhatelmas requested a review from a team as a code owner February 26, 2026 15:28
@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Improved error status code handling for more accurate HTTP responses in edge cases.
  • Chores

    • Updated code quality tooling configurations (ESLint, Prettier, Biome).
    • Revised development scripts for formatting and linting workflows.
    • Standardized formatting across configuration and monitoring files.
  • Documentation

    • Added code quality command references to developer documentation.

Walkthrough

This PR primarily normalizes formatting and quoting across the repo (YAML/JSON/JS/TS), updates Prettier and Biome configuration (.prettierrc, .prettierignore, biome.jsonc), removes plugin:prettier/recommended from ESLint, and updates formatting scripts in package.json. Many docker-compose, monitoring, and Grafana dashboard files were reformatted (array/quote normalization). Most changes are non-functional, but one behavioral change in src/http/error-handler.ts adjusts statusCode selection when error.userStatusCode is truthy: it now returns 500 if renderableError.statusCode === '500', otherwise 400.

Possibly related PRs

  • chore: use biome for format #872: Updates formatting/tooling configuration (biome.jsonc and package.json scripts), closely related to the formatting and script changes in this PR.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.prettierignore:
- Line 9: Remove the incorrect ignore entry "src/test/db/docker-compose.yml"
from .prettierignore; open the .prettierignore file, delete the line containing
that path (the stray entry referencing src/test/db/docker-compose.yml), and save
the file so Prettier will no longer reference a non-existent file.

ℹ️ Review info

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Cache: Disabled due to Reviews > Disable Cache setting

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e6d9a33 and 83030ef.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (42)
  • .docker/docker-compose-infra.yml
  • .docker/docker-compose-monitoring.yml
  • .docker/pgbouncer/README.md
  • .eslintrc.js
  • .github/workflows/cli.yaml
  • .github/workflows/docs.yml
  • .github/workflows/mirror.yml
  • .github/workflows/release.yml
  • .prettierignore
  • .prettierrc
  • README.md
  • babel.config.cjs
  • biome.jsonc
  • docker-compose-multi-tenant.yml
  • docker-compose.yml
  • jest.sequencer.cjs
  • monitoring/grafana/config/dashboards/default.yml
  • monitoring/grafana/config/datasources/datacourse.yml
  • monitoring/grafana/dashboards/postgres.json
  • monitoring/grafana/dashboards/storage-otel.json
  • monitoring/grafana/dashboards/storage.json
  • monitoring/grafana/dashboards/supavisor.json
  • monitoring/otel/config/otel-collector-config.yml
  • monitoring/prometheus/prometheus.yml
  • package.json
  • src/http/error-handler.ts
  • src/http/plugins/metrics.ts
  • src/http/routes/admin/tenants.ts
  • src/http/routes/s3/commands/put-object.ts
  • src/http/routes/s3/router.ts
  • src/internal/database/migrations/migrate.ts
  • src/internal/monitoring/otel-metrics.ts
  • src/internal/monitoring/otel-tracing.ts
  • src/internal/queue/queue.ts
  • src/internal/sharding/architecture.md
  • src/storage/database/knex.ts
  • src/storage/protocols/iceberg/catalog/rest-catalog-client.ts
  • src/storage/protocols/tus/postgres-locker.ts
  • src/test/jwt.test.ts
  • src/test/rls.test.ts
  • src/test/rls_tests.yaml
  • tsconfig.json

Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.docker/docker-compose-infra.yml:
- Around line 49-113: The commented supavisor/supavisor_setup block contains
committed secrets (the Bearer token in the PUT request and secret-like env
values such as SECRET_KEY_BASE, VAULT_ENC_KEY, API_JWT_SECRET,
METRICS_JWT_SECRET); remove these real-looking values and replace them with
placeholders or references to environment variables (e.g. use
${SUPAVISOR_API_TOKEN}, ${SECRET_KEY_BASE}) inside the supavisor and
supavisor_setup blocks so no secrets remain in the comment, and ensure any
exposed tokens are rotated/revoked if they were ever valid.

ℹ️ Review info

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Cache: Disabled due to Reviews > Disable Cache setting

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 83030ef and 4115c4b.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (42)
  • .docker/docker-compose-infra.yml
  • .docker/docker-compose-monitoring.yml
  • .docker/pgbouncer/README.md
  • .eslintrc.js
  • .github/workflows/cli.yaml
  • .github/workflows/docs.yml
  • .github/workflows/mirror.yml
  • .github/workflows/release.yml
  • .prettierignore
  • .prettierrc
  • README.md
  • babel.config.cjs
  • biome.jsonc
  • docker-compose-multi-tenant.yml
  • docker-compose.yml
  • jest.sequencer.cjs
  • monitoring/grafana/config/dashboards/default.yml
  • monitoring/grafana/config/datasources/datacourse.yml
  • monitoring/grafana/dashboards/postgres.json
  • monitoring/grafana/dashboards/storage-otel.json
  • monitoring/grafana/dashboards/storage.json
  • monitoring/grafana/dashboards/supavisor.json
  • monitoring/otel/config/otel-collector-config.yml
  • monitoring/prometheus/prometheus.yml
  • package.json
  • src/http/error-handler.ts
  • src/http/plugins/metrics.ts
  • src/http/routes/admin/tenants.ts
  • src/http/routes/s3/commands/put-object.ts
  • src/http/routes/s3/router.ts
  • src/internal/database/migrations/migrate.ts
  • src/internal/monitoring/otel-metrics.ts
  • src/internal/monitoring/otel-tracing.ts
  • src/internal/queue/queue.ts
  • src/internal/sharding/architecture.md
  • src/storage/database/knex.ts
  • src/storage/protocols/iceberg/catalog/rest-catalog-client.ts
  • src/storage/protocols/tus/postgres-locker.ts
  • src/test/jwt.test.ts
  • src/test/rls.test.ts
  • src/test/rls_tests.yaml
  • tsconfig.json
✅ Files skipped from review due to trivial changes (5)
  • src/test/rls_tests.yaml
  • src/storage/protocols/tus/postgres-locker.ts
  • babel.config.cjs
  • src/http/plugins/metrics.ts
  • monitoring/otel/config/otel-collector-config.yml
🚧 Files skipped from review as they are similar to previous changes (23)
  • src/test/jwt.test.ts
  • src/test/rls.test.ts
  • biome.jsonc
  • README.md
  • .github/workflows/cli.yaml
  • tsconfig.json
  • .docker/pgbouncer/README.md
  • src/http/routes/s3/commands/put-object.ts
  • monitoring/grafana/config/dashboards/default.yml
  • src/storage/protocols/iceberg/catalog/rest-catalog-client.ts
  • .github/workflows/release.yml
  • monitoring/grafana/dashboards/supavisor.json
  • monitoring/grafana/dashboards/storage-otel.json
  • monitoring/grafana/dashboards/storage.json
  • src/internal/sharding/architecture.md
  • monitoring/prometheus/prometheus.yml
  • src/http/routes/admin/tenants.ts
  • monitoring/grafana/config/datasources/datacourse.yml
  • src/internal/database/migrations/migrate.ts
  • .github/workflows/mirror.yml
  • src/internal/monitoring/otel-metrics.ts
  • src/storage/database/knex.ts
  • docker-compose.yml

@ferhatelmas ferhatelmas merged commit 91fefd6 into master Feb 26, 2026
2 checks passed
@ferhatelmas ferhatelmas deleted the ferhat/format branch February 26, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants