chore: switch into biome and format all md/yml via prettier#877
chore: switch into biome and format all md/yml via prettier#877ferhatelmas merged 1 commit intomasterfrom
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR primarily normalizes formatting and quoting across the repo (YAML/JSON/JS/TS), updates Prettier and Biome configuration (.prettierrc, .prettierignore, biome.jsonc), removes Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
83030ef to
f84bebb
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.prettierignore:
- Line 9: Remove the incorrect ignore entry "src/test/db/docker-compose.yml"
from .prettierignore; open the .prettierignore file, delete the line containing
that path (the stray entry referencing src/test/db/docker-compose.yml), and save
the file so Prettier will no longer reference a non-existent file.
ℹ️ Review info
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Cache: Disabled due to Reviews > Disable Cache setting
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (42)
.docker/docker-compose-infra.yml.docker/docker-compose-monitoring.yml.docker/pgbouncer/README.md.eslintrc.js.github/workflows/cli.yaml.github/workflows/docs.yml.github/workflows/mirror.yml.github/workflows/release.yml.prettierignore.prettierrcREADME.mdbabel.config.cjsbiome.jsoncdocker-compose-multi-tenant.ymldocker-compose.ymljest.sequencer.cjsmonitoring/grafana/config/dashboards/default.ymlmonitoring/grafana/config/datasources/datacourse.ymlmonitoring/grafana/dashboards/postgres.jsonmonitoring/grafana/dashboards/storage-otel.jsonmonitoring/grafana/dashboards/storage.jsonmonitoring/grafana/dashboards/supavisor.jsonmonitoring/otel/config/otel-collector-config.ymlmonitoring/prometheus/prometheus.ymlpackage.jsonsrc/http/error-handler.tssrc/http/plugins/metrics.tssrc/http/routes/admin/tenants.tssrc/http/routes/s3/commands/put-object.tssrc/http/routes/s3/router.tssrc/internal/database/migrations/migrate.tssrc/internal/monitoring/otel-metrics.tssrc/internal/monitoring/otel-tracing.tssrc/internal/queue/queue.tssrc/internal/sharding/architecture.mdsrc/storage/database/knex.tssrc/storage/protocols/iceberg/catalog/rest-catalog-client.tssrc/storage/protocols/tus/postgres-locker.tssrc/test/jwt.test.tssrc/test/rls.test.tssrc/test/rls_tests.yamltsconfig.json
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
f84bebb to
4115c4b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.docker/docker-compose-infra.yml:
- Around line 49-113: The commented supavisor/supavisor_setup block contains
committed secrets (the Bearer token in the PUT request and secret-like env
values such as SECRET_KEY_BASE, VAULT_ENC_KEY, API_JWT_SECRET,
METRICS_JWT_SECRET); remove these real-looking values and replace them with
placeholders or references to environment variables (e.g. use
${SUPAVISOR_API_TOKEN}, ${SECRET_KEY_BASE}) inside the supavisor and
supavisor_setup blocks so no secrets remain in the comment, and ensure any
exposed tokens are rotated/revoked if they were ever valid.
ℹ️ Review info
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Cache: Disabled due to Reviews > Disable Cache setting
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (42)
.docker/docker-compose-infra.yml.docker/docker-compose-monitoring.yml.docker/pgbouncer/README.md.eslintrc.js.github/workflows/cli.yaml.github/workflows/docs.yml.github/workflows/mirror.yml.github/workflows/release.yml.prettierignore.prettierrcREADME.mdbabel.config.cjsbiome.jsoncdocker-compose-multi-tenant.ymldocker-compose.ymljest.sequencer.cjsmonitoring/grafana/config/dashboards/default.ymlmonitoring/grafana/config/datasources/datacourse.ymlmonitoring/grafana/dashboards/postgres.jsonmonitoring/grafana/dashboards/storage-otel.jsonmonitoring/grafana/dashboards/storage.jsonmonitoring/grafana/dashboards/supavisor.jsonmonitoring/otel/config/otel-collector-config.ymlmonitoring/prometheus/prometheus.ymlpackage.jsonsrc/http/error-handler.tssrc/http/plugins/metrics.tssrc/http/routes/admin/tenants.tssrc/http/routes/s3/commands/put-object.tssrc/http/routes/s3/router.tssrc/internal/database/migrations/migrate.tssrc/internal/monitoring/otel-metrics.tssrc/internal/monitoring/otel-tracing.tssrc/internal/queue/queue.tssrc/internal/sharding/architecture.mdsrc/storage/database/knex.tssrc/storage/protocols/iceberg/catalog/rest-catalog-client.tssrc/storage/protocols/tus/postgres-locker.tssrc/test/jwt.test.tssrc/test/rls.test.tssrc/test/rls_tests.yamltsconfig.json
✅ Files skipped from review due to trivial changes (5)
- src/test/rls_tests.yaml
- src/storage/protocols/tus/postgres-locker.ts
- babel.config.cjs
- src/http/plugins/metrics.ts
- monitoring/otel/config/otel-collector-config.yml
🚧 Files skipped from review as they are similar to previous changes (23)
- src/test/jwt.test.ts
- src/test/rls.test.ts
- biome.jsonc
- README.md
- .github/workflows/cli.yaml
- tsconfig.json
- .docker/pgbouncer/README.md
- src/http/routes/s3/commands/put-object.ts
- monitoring/grafana/config/dashboards/default.yml
- src/storage/protocols/iceberg/catalog/rest-catalog-client.ts
- .github/workflows/release.yml
- monitoring/grafana/dashboards/supavisor.json
- monitoring/grafana/dashboards/storage-otel.json
- monitoring/grafana/dashboards/storage.json
- src/internal/sharding/architecture.md
- monitoring/prometheus/prometheus.yml
- src/http/routes/admin/tenants.ts
- monitoring/grafana/config/datasources/datacourse.yml
- src/internal/database/migrations/migrate.ts
- .github/workflows/mirror.yml
- src/internal/monitoring/otel-metrics.ts
- src/storage/database/knex.ts
- docker-compose.yml
What kind of change does this PR introduce?
chore
What is the current behavior?
No consistent formatting for all file types.
What is the new behavior?
Use biome for json, jsonc, ts, js.
Use prettier for markdown and yaml. Biome support is coming.
Additional context
Enable formatting for all files. Previously, non-src files weren't formatted.