fix: vector list wildcards and pagination#894
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe changes enhance pagination and input handling in the vector storage layer. The code adds input sanitization using escapeLike for LIKE-pattern queries in bucket and index prefix filtering. The pagination mechanism is adjusted to use the name column instead of id for token-based pagination in the indexes listing. The VectorStoreManager.listIndexes method is updated to return a nextToken field alongside indexes. Comprehensive tests are added to validate pagination behavior with nextToken and prefix filtering with special character handling. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Vector index listing can paginate second page onward.
Like operator wildcards aren't escaped.
What is the new behavior?
Fix pagination continuation and wildcards in prefix filters. Increase test coverage.
Additional context
None