fix: manual admin tenant migration state recording#939
Merged
ferhatelmas merged 1 commit intomasterfrom Mar 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes admin-triggered tenant migrations not recording migration completion state in the multitenant tenants table, bringing manual admin runs in line with other migration execution paths.
Changes:
- Use
updateTenantMigrationsStateto consistently mark tenant migrations asCOMPLETEDafter successful admin-initiated runs. - Extract a small helper (
markTenantMigrationsCompleted) to deduplicate the state update logic across multiple admin tenant routes. - Add tests verifying that manual admin tenant migrations persist
migrations_version/migrations_status, including whendbMigrationFreezeAtis configured.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/http/routes/admin/tenants.ts | Ensures successful admin-triggered tenant migrations record completed migration state via shared helper. |
| src/test/admin-migrations.test.ts | Adds regression tests asserting tenant migration state is recorded (normal + frozen target). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
219c5de to
5e1d1bd
Compare
TylerHillery
approved these changes
Mar 27, 2026
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
5e1d1bd to
ad26de0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Manual migration run via admin doesn't update tenant migration status in multitenant database.
What is the new behavior?
State is correctly updated.
Additional context
Extracted a helper for the same state updating query.