fix: handle json content type in delete tenant#956
Merged
ferhatelmas merged 1 commit intomasterfrom Mar 31, 2026
Merged
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
fenos
approved these changes
Mar 31, 2026
There was a problem hiding this comment.
Pull request overview
This PR makes the admin tenant DELETE endpoint permissive when clients send Content-Type: application/json with an empty body, avoiding JSON parsing failures and improving client convenience for the admin app.
Changes:
- Encapsulate the admin tenant DELETE route and override the JSON content-type parser to treat an empty body as
nullwhile preserving normal JSON parsing when a body is present. - Add a regression test ensuring an empty JSON DELETE request succeeds and returns
204.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/http/routes/admin/tenants.ts |
Adds an encapsulated application/json parser override for the tenant DELETE route to allow empty JSON bodies. |
src/test/admin-tenants.test.ts |
Adds a test verifying DELETE /tenants/:tenantId accepts Content-Type: application/json with an empty payload and returns 204. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 23805755274Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor, bug fix.
What is the current behavior?
While deleting a tenant in admin app, if content-type is set to json, body is needed.
What is the new behavior?
Body isn't needed but also there is no need to fail the request. Make it permissive to accept empty json body.
Additional context
Can be seen related to #953 partially due to implementation but the reason is completely different (client convenience here vs genuine bug).